PR

【3/23】技玉ガチャ #1655

wada opened this at 2022-03-22T14:10:36; closed

Description

opened by wada at 2022-03-22T14:10:36; updated 2022-03-24T11:35:03

概要

3月ガチャ #1625
defineの期間をmaster_monthly_skillball_gacha参照に変更
TOP画像をイベントごとに変更

web : skill_ball_0325
db : skill_ball_0325

db更新

master_card_skill
master_monthly_skillball_gacha
master_monthly_skillball_gacha_item

テスト方法、確認した内容

期間と画像の取得方法を変更したので、期間外・期間中の画像表示、処理を確認おねがしいます。

Comment

#17968 by wada at 2022-03-22T14:10:45; updated 2022-03-22T14:10:45

@kouho
レビューお願いします。

Comment

#17990 by kouho at 2022-03-22T17:01:18; updated 2022-03-22T17:01:18

@wada
define_yの以下の箇所でundefined erorが出ているように見えますので確認お願いいたします。

	$_df['skillball_event']['ticket_start_time'] = $_df['skillball_event']['start_time'];			//技玉ガチャのチケット交換所の開始時間
	$_df['skillball_event']['ticket_end_time'] = $_df['skillball_event']['end_time']+3600*24*2;		//技玉ガチャのチケット交換所の終了時間

Comment

#17993 by wada at 2022-03-22T17:23:30; updated 2022-03-22T17:23:30

@kouho
ありがとうございます。修正しました。

Comment

#18007 by kouho at 2022-03-23T09:58:07; updated 2022-03-23T09:58:07

@wada
確認OKです

kouho add_label at 2022-03-23T09:58:13: 皇甫 LGTM
wada merge at 2022-03-23T10:16:04: 【3/23】技玉ガチャ
wada close at 2022-03-23T10:16:04: Close
wada refer at 2022-03-24T11:35:03: 1669:【3/24】技玉ガチャ、ヤマダキャンペーン

Commit range

base1f039666ae4adc28bf429a0578b4a74dfdf09066
head9487426a684e71046851d9f23ab1605d8fe07e0d
base branchjolly/jr-web:develop
head branchjolly/jr-web:skill_ball_0325

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed28 filesView patch
statusfile
modifiedlib/conf/define_y.inc
modifiedlib/models/Gacha_skillball.php
modifiedlib/public/Bar-Default.inc
modifiedlib/public/Bar-SkillBallGachaCheck.inc
modifiedlib/public/Bar-SkillBallGachaExec.inc
modifiedlib/public/Bar-TreasureBoxGachaCheck.inc
modifiedlib/public/Bar-TreasureBoxGachaExec.inc
modifiedpublic_html/img/banner/banner_skillball_gacha_start_1.jpg
modifiedpublic_html/img/banner/banner_skillball_gacha_start_2.jpg
addedpublic_html/img/info_event/info_event_396_1.jpg
addedpublic_html/img/info_event/info_event_396_2.jpg
addedpublic_html/img/info_jrye/1357/info1.jpg
addedpublic_html/img/info_jrye/1357/info10.jpg
addedpublic_html/img/info_jrye/1357/info3.jpg
addedpublic_html/img/info_jrye/1357/info4.jpg
addedpublic_html/img/info_jrye/1357/info5.jpg
addedpublic_html/img/info_jrye/1357/info6.jpg
addedpublic_html/img/info_jrye/1357/info7.jpg
addedpublic_html/img/info_jrye/1357/info8.jpg
addedpublic_html/img/info_jrye/1357/info9.jpg
addedpublic_html/img/info_jrye/1357/top.jpg
addedpublic_html/img/info_jrye/SkillBallInfo/common/period.jpg
addedpublic_html/img/info_jrye/SkillBallInfo/common/skill_change_item.jpg
addedpublic_html/img/info_jrye/SkillBallInfo/common/what.jpg
modifiedpublic_html/template/Bar-Default.tpl
modifiedpublic_html/template/Bar-SkillBallMedalGachaCheck.tpl
modifiedpublic_html/template/Shop-Assortment.tpl
modifiedpublic_html/template/Shop.tpl
Patch body is stored as a separate file to keep this page lightweight.