jolly/jr-web #2634 【2/27】島テーマ告知画像とバナー画像

Description

opened by kouho at 2023-02-27T11:52:11; updated 2023-02-28T11:37:36

概要

島テーマの告知画像用のPRです。
https://docs.google.com/spreadsheets/d/1v3kshIhPBNu8uWK8SfnTxkuJXx1UKJIBETtIIa-K5OU/edit#gid=2120632986

テスト方法、確認した内容

以下の期間が正しいか確認

SP期間
建物名
イベントタイトルが正しいか

TODO

Comment

#26041 by kouho at 2023-02-27T11:52:28; updated 2023-02-27T11:52:28

@wada @nakato
確認お願いいたします

Comment

#26046 by wada at 2023-02-27T12:03:04; updated 2023-02-27T12:03:04

@kouho
変化する島テーマ名が統一されていません。

> public_html/img/info_event/info_event_638_2.jpg
public_html/img/info_jrye/2096/info2_0.jpg
public_html/img/info_jrye/2096/info4.jpg

Comment

#26047 by kouho at 2023-02-27T12:26:39; updated 2023-02-27T12:26:39

@wada
> 変化する島テーマ名が統一されていません。
>
public_html/img/info_event/info_event_638_2.jpg
public_html/img/info_jrye/2096/info2_0.jpg
public_html/img/info_jrye/2096/info4.jpg

島テーマ名が猫たちの大集会なのでそちらに統一しました。

Comment

#26053 by wada at 2023-02-27T13:32:23; updated 2023-02-27T13:32:23

@kouho
ありがとうございます。確認 OKです。

wada add_label at 2023-02-27T13:32:26: 和田 LGTM

nakato add_label at 2023-02-27T13:50:18: 中戸LGTM

Comment

#26056 by nakato at 2023-02-27T13:50:35; updated 2023-02-27T13:50:35

@kouho
確認OKです。

kouho merge at 2023-02-28T11:37:36: 【2/27】島テーマ告知画像とバナー画像

kouho close at 2023-02-28T11:37:36: Close

Metadata

type	Pull Request
state	closed
opened by	kouho
assigned	kouho
registered	2023-02-27T11:52:11
updated	2023-02-28T11:37:36

Labels

レビュー待ちマスタへマージ和田 LGTM中戸LGTM

Pull Request

base	jolly/jr-web:master
head	jolly/jr-web:info_image_build_10073
from	68cbcefd1224afc9b2cacbd1b87c0eae28891f0f
to	df0e71b9082dd09bac5b3ba7bf02f5378e9645de

Commit range

base	`68cbcefd1224afc9b2cacbd1b87c0eae28891f0f`
head	`df0e71b9082dd09bac5b3ba7bf02f5378e9645de`
base branch	jolly/jr-web:master
head branch	jolly/jr-web:info_image_build_10073

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.

Files changed18 filesView patch

status	file
added	`public_html/img/banner/build_10073_1_1.jpg`
added	`public_html/img/banner/build_10073_1_2.jpg`
added	`public_html/img/banner/build_10073_2_1.jpg`
added	`public_html/img/banner/build_10073_2_2.jpg`
added	`public_html/img/info_event/info_event_638_1.jpg`
added	`public_html/img/info_event/info_event_638_2.jpg`
added	`public_html/img/info_jrye/2095/info1.jpg`
added	`public_html/img/info_jrye/2095/info3_1.jpg`
added	`public_html/img/info_jrye/2095/info3_4.jpg`
added	`public_html/img/info_jrye/2095/info5.jpg`
added	`public_html/img/info_jrye/2095/info7.jpg`
added	`public_html/img/info_jrye/2096/info1.jpg`
added	`public_html/img/info_jrye/2096/info2.jpg`
added	`public_html/img/info_jrye/2096/info2_0.jpg`
added	`public_html/img/info_jrye/2096/info2_1.jpg`
added	`public_html/img/info_jrye/2096/info3.jpg`
added	`public_html/img/info_jrye/2096/info3_1.jpg`
added	`public_html/img/info_jrye/2096/info4.jpg`

Patch body is stored as a separate file to keep this page lightweight.