PR

【4/19】技玉バナー切り替え対応 #2726

wada opened this at 2023-04-17T17:12:14; closed

Description

opened by wada at 2023-04-17T17:12:14; updated 2023-04-19T11:00:11

概要

開催回でバナー画像のファイル名を書き換える必要が出たため、master_monthly_skillball_gacha.infoをバナーIDに利用

  • 0の場合は、banner_skillball_gacha_start_1.jpg(既存バナー)
  • 1以上の場合は、banner_skillball_gacha_{info}_1.jpg

テスト方法、確認した内容

過去の技玉ガチャを開催状態にして、master_monthly_skillball_gacha.infoが以下の状態の表示を確認

  • info=0
  • info=132(バナー画像が存在するのが132だけなので)

Comment

#27026 by wada at 2023-04-17T17:12:45; updated 2023-04-17T17:12:45

@kouho
レビューお願いしいます。

kouho add_label at 2023-04-18T15:17:22: 皇甫 LGTM

Comment

#27049 by kouho at 2023-04-18T15:17:33; updated 2023-04-18T15:17:33

@wada
確認OKです

wada merge at 2023-04-19T11:00:04: 【4/19】技玉バナー切り替え対応
wada close at 2023-04-19T11:00:04: Close
wada delete_branch at 2023-04-19T11:00:11: skillball_gacha_info

Commit range

baseab3fd2ea98cf137673f30d774d8d988e0a5f2678
headf6769ec6a9885f3c69a3018fc529bebce1206079
base branchjolly/jr-web:master
head branchjolly/jr-web:skillball_gacha_info

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed9 filesView patch
statusfile
addedpublic_html/img/banner/banner_skillball_gacha_132_1.jpg
addedpublic_html/img/banner/banner_skillball_gacha_132_2.jpg
modifiedpublic_html/template/Bar-Default.tpl
modifiedpublic_html/template/Default.tpl
modifiedpublic_html/template/Event.tpl
modifiedpublic_html/template/History-SkillBallMedal.tpl
modifiedpublic_html/template/Main.tpl
modifiedpublic_html/template/Quest-Detail.tpl
modifiedpublic_html/template/Shop.tpl
Patch body is stored as a separate file to keep this page lightweight.