Archive / jolly / jr-web
PR

【即時】新規登録ユーザーキャンペーンバナー表示対応 #2846

kouho opened this at 2023-06-09T19:18:28; closed

Description

opened by kouho at 2023-06-09T19:18:28; updated 2023-06-09T19:52:12

概要

以下のキャンペーンでのバナー画像表示用の対応
https://docs.google.com/spreadsheets/d/17ma0rDHZnIdCrvN9bJwIsWK1yyr6luaQHPcEu8SrXBI/edit#gid=1334258246

wada add_label at 2023-06-09T19:31:33: 和田 LGTM

Comment

#28088 by wada at 2023-06-09T19:31:41; updated 2023-06-09T19:31:41

@kouho
確認OKです。

Comment

#28089 by kouho at 2023-06-09T19:52:08; updated 2023-06-09T19:52:08

@wada
確認ありがとうございます。秒数も59に修正しました。

kouho merge at 2023-06-09T19:52:12: 【即時】新規登録ユーザーキャンペーンバナー表示対応
kouho close at 2023-06-09T19:52:12: Close

commit comment

#176 by wada at 2023-06-09T19:31:21; lib/conf/define_y.inc / old:None new:2501
461924a03fccf308608217b1c02e7ffa505eace0

@kouho
特に気にする必要ないかもしれませんが、秒は0で良いですか？

Commit range

basea9840346d5c08cf2dd07fd38824aa74efa49f593
head7b0c44a2c910edb4a9086c05b6bfd444ce3603d4
base branchjolly/jr-web:master
head branchjolly/jr-web:rookie_banner

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed5 filesView patch
statusfile
modifiedlib/conf/class/EventScheduleConfig.class.php
modifiedlib/conf/define_y.inc
modifiedlib/models/Banner.php
addedpublic_html/img/banner/Campaign/banner_rookie_camaign_1_1.jpg
addedpublic_html/img/banner/Campaign/banner_rookie_camaign_1_2.jpg
Patch body is stored as a separate file to keep this page lightweight.

Review comment

#176 by wada at 2023-06-09T19:31:21; lib/conf/define_y.inc / old:None new:2501
461924a03fccf308608217b1c02e7ffa505eace0

@kouho
特に気にする必要ないかもしれませんが、秒は0で良いですか？