jolly/jr-web #2904 【7/3】島テーマ画像登録

Description

opened by suzuki at 2023-07-03T14:59:01; updated 2023-07-04T11:39:50

仕様書

https://docs.google.com/spreadsheets/d/1AiCzT4y62Uk8ENSs_nx7dggE7N2SAKH1dRN2j3_M9oU/edit#gid=2120632986

【6/28】GIBJapan作業依頼 jolly/jr-web#2889

Comment

#28630 by suzuki at 2023-07-03T14:59:18; updated 2023-07-03T14:59:18

@wada @kouho

レビューをお願いします。

Comment

#28658 by wada at 2023-07-03T18:37:07; updated 2023-07-03T18:37:07

@suzuki
以下のバナー画像について、過去のPRも間違っていたようです。
正しくは、idの前にbuildがつきます。

#誤
public_html/img/banner/10054_1_1.jpg
public_html/img/banner/10054_1_2.jpg
public_html/img/banner/10054_2_1.jpg
public_html/img/banner/10054_2_2.jpg
#正
public_html/img/banner/build_10054_1_1.jpg
public_html/img/banner/build_10054_1_2.jpg
public_html/img/banner/build_10054_2_1.jpg
public_html/img/banner/build_10054_2_2.jpg

---
ファイル名のidの前にスペースが含まれています。

public_html/img/info_event/info_event_ 729_1.jpg
public_html/img/info_event/info_event_ 729_2.jpg

Comment

#28659 by wada at 2023-07-03T18:42:21; updated 2023-07-03T18:42:21

@suzuki
画像内に過去のイベント名「かえるの合唱」が2箇所含まれています。
<div style="width:400px;">
!info5</div>

kouho merge at 2023-07-04T11:39:50: 【7/3】島テーマ画像登録

kouho close at 2023-07-04T11:39:50: Close

Metadata

type	Pull Request
state	closed
opened by	suzuki
assigned	suzuki
registered	2023-07-03T14:59:01
updated	2023-07-04T11:39:50

Labels

レビュー待ちマスタへマージ

Pull Request

base	jolly/jr-web:master
head	jolly/jr-web:image_island0707
from	e9667e1434adbf220e0ab7d73e254bbfb47b3c94
to	f5cc2664b7f34fc3ea74bffc86fd51bb99d49218

Commit range

base	`e9667e1434adbf220e0ab7d73e254bbfb47b3c94`
head	`f5cc2664b7f34fc3ea74bffc86fd51bb99d49218`
base branch	jolly/jr-web:master
head branch	jolly/jr-web:image_island0707

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.

Files changed18 filesView patch

status	file
added	`public_html/img/banner/build_10054_1_1.jpg`
added	`public_html/img/banner/build_10054_1_2.jpg`
added	`public_html/img/banner/build_10054_2_1.jpg`
added	`public_html/img/banner/build_10054_2_2.jpg`
added	`public_html/img/info_event/info_event_729_1.jpg`
added	`public_html/img/info_event/info_event_729_2.jpg`
added	`public_html/img/info_jrye/2378/info1.jpg`
added	`public_html/img/info_jrye/2378/info3_1.jpg`
added	`public_html/img/info_jrye/2378/info3_4.jpg`
added	`public_html/img/info_jrye/2378/info5.jpg`
added	`public_html/img/info_jrye/2378/info7.jpg`
added	`public_html/img/info_jrye/2379/info1.jpg`
added	`public_html/img/info_jrye/2379/info2.jpg`
added	`public_html/img/info_jrye/2379/info2_0.jpg`
added	`public_html/img/info_jrye/2379/info2_1.jpg`
added	`public_html/img/info_jrye/2379/info3.jpg`
added	`public_html/img/info_jrye/2379/info3_1.jpg`
added	`public_html/img/info_jrye/2379/info4.jpg`

Patch body is stored as a separate file to keep this page lightweight.