PR

【1/30】復刻温泉街ガチャ・温泉街ガチャ #3888

kouho opened this at 2025-01-29T11:03:27; closed

Description

opened by kouho at 2025-01-29T11:03:27; updated 2025-01-31T15:57:31

概要

復刻温泉街ガチャ
https://docs.google.com/spreadsheets/d/1qniv96ffMDlYLMndsJptdYAWlq5asElUOLPwaCDtWmw/edit?gid=198966341#gid=198966341

温泉街ガチャ
https://docs.google.com/spreadsheets/d/1Rw3ITCIG9fsrQdag_SEk4NaWf4frJAdTU4qb_prZyFA/edit?gid=198966341#gid=198966341

カードデータ更新プルリクと交換所プルリクもマージしています。

TODO

  • [x] ドリンク画像と効果量の確認

Comment

#38638 by kouho at 2025-01-29T11:03:37; updated 2025-01-29T11:03:37

@wada
レビューお願いいたします

Comment

#38640 by wada at 2025-01-29T15:11:57; updated 2025-01-29T15:11:57

@kouho
カード説明のモーダルが表示されません。

LimitBreak-List.tplガチャへボタンの遷移先にSPガチャ追加をお願いします。

Comment

#38641 by wada at 2025-01-29T15:17:49; updated 2025-01-29T15:17:49

@kouho
> gacha/509/info_strong_item.jpg

<img src="https://git.dev.d-es.co.jp/gitbucket/jolly/jr-web/_attached/17381312637088Ux2tLGd4d" width="300">

...など他にもあるよ!とありますが、主語が強化アイテムだと記載のアイテム以外にはありません。

wada add_label at 2025-01-29T15:17:55: コメントあり

Comment

#38668 by kouho at 2025-01-30T15:24:09; updated 2025-01-30T15:24:09

@wada
確認ありがとうございます。以下の画像を修正しました
> ...など他にもあるよ!とありますが、主語が強化アイテムだと記載のアイテム以外にはありません。

Comment

#38669 by kouho at 2025-01-30T16:03:41; updated 2025-01-30T16:03:41

@wada
以下も修正いたしました。
> カード説明のモーダルが表示されません。

> LimitBreak-List.tplのガチャへボタンの遷移先にSPガチャ追加をお願いします。

Comment

#38670 by wada at 2025-01-30T18:43:22; updated 2025-01-30T18:43:22

@kouho
モーダル表示修正時にpublic_html/template/Bar-SPGachaYamada.tplsが残っています。

Comment

#38671 by kouho at 2025-01-31T10:31:38; updated 2025-01-31T10:31:38

@wada
確認ありがとうございます。以下も修正いたしました。
> モーダル表示修正時にpublic_html/template/Bar-SPGachaYamada.tplでsが残っています。

Comment

#38675 by wada at 2025-01-31T14:16:36; updated 2025-01-31T14:16:36

@kouho
確認OKです。

wada delete_label at 2025-01-31T14:16:39: コメントあり
wada add_label at 2025-01-31T14:16:40: 和田 LGTM
kouho merge at 2025-01-31T15:57:31: 【1/30】復刻温泉街ガチャ・温泉街ガチャ
kouho close at 2025-01-31T15:57:31: Close

Commit range

base2fb776e44bee16c3205138c921cd4020a4321d39
head99fa15a05fb5fb5c4b2f7bf2f93abd73b03b6c04
base branchjolly/jr-web:master
head branchjolly/jr-web:gacha_season_0203

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed132 filesView patch
statusfile
modifiedlib/SubFunc.inc
modifiedlib/conf/class/SPGachaConfig.class.php
modifiedlib/conf/define_y.inc
addedlib/models/Limited_trade_shop_helper.php
modifiedlib/models/Present_receive.php
modifiedlib/public/Bar-Default.inc
modifiedlib/public/Bar-SPGacha.inc
modifiedlib/public/Bar-SPGachaResult.inc
modifiedlib/public/LimitedTradeShop-Default.inc
addedlib/public/LimitedTradeShop-Exec.inc
modifiedlib/public/Present-Default.inc
modifiedlib/public/Present-History.inc
addedpublic_html/img/gacha/508/banner_gacha508.jpg
addedpublic_html/img/gacha/508/banner_gacha508_2.jpg
addedpublic_html/img/gacha/508/gacha508.jpg
addedpublic_html/img/gacha/508/gacha508_2.jpg
addedpublic_html/img/gacha/508/gacha_result_top.jpg
addedpublic_html/img/gacha/508/info_card_bonus.jpg
addedpublic_html/img/gacha/508/info_drink.jpg
addedpublic_html/img/gacha/508/info_strong_item.jpg
addedpublic_html/img/gacha/508/info_tokupan_and_item.jpg
addedpublic_html/img/gacha/508/info_trade_shop.jpg
addedpublic_html/img/gacha/508/naiyou.jpg
addedpublic_html/img/gacha/508/status0.jpg
addedpublic_html/img/gacha/508/status0_2.jpg
addedpublic_html/img/gacha/508/status1.jpg
addedpublic_html/img/gacha/508/status1_2.jpg
addedpublic_html/img/gacha/508/status2.jpg
addedpublic_html/img/gacha/508/status3.jpg
addedpublic_html/img/gacha/508/title.jpg
addedpublic_html/img/gacha/509/banner_gacha509.jpg
addedpublic_html/img/gacha/509/banner_gacha509_2.jpg
addedpublic_html/img/gacha/509/gacha509.jpg
addedpublic_html/img/gacha/509/gacha509_2.jpg
addedpublic_html/img/gacha/509/gk.jpg
addedpublic_html/img/gacha/509/info_card_bonus.jpg
addedpublic_html/img/gacha/509/info_drink.jpg
addedpublic_html/img/gacha/509/info_strong_item.jpg
addedpublic_html/img/gacha/509/info_tokupan_and_item.jpg
addedpublic_html/img/gacha/509/info_trade_shop.jpg
addedpublic_html/img/gacha/509/naiyou.jpg
addedpublic_html/img/gacha/509/status0.jpg
addedpublic_html/img/gacha/509/status1.jpg
addedpublic_html/img/gacha/509/status1_2.jpg
addedpublic_html/img/gacha/509/status2.jpg
addedpublic_html/img/gacha/509/status3.jpg
addedpublic_html/img/gacha/509/status3_2.jpg
addedpublic_html/img/gacha/509/title.jpg
addedpublic_html/img/gacha/gacha_coin_object2_ts1.png
addedpublic_html/img/gacha/gacha_coin_object508.png
addedpublic_html/img/gacha/gacha_coin_object508_2.png
addedpublic_html/img/gacha/gacha_coin_object509.png
addedpublic_html/img/gacha/gacha_coin_object509_2.png
addedpublic_html/img/gacha/gacha_coin_object_sp_step1_ts1.png
addedpublic_html/img/gacha/gacha_coin_object_sp_step2_ts1.png
addedpublic_html/img/info_event/info_event_1261_1.jpg
addedpublic_html/img/info_event/info_event_1261_2.jpg
addedpublic_html/img/info_event/info_event_1262_1.jpg
addedpublic_html/img/info_event/info_event_1262_2.jpg
addedpublic_html/img/info_jrye/4163/info1.jpg
addedpublic_html/img/info_jrye/4163/info3.jpg
addedpublic_html/img/info_jrye/4163/info4.jpg
addedpublic_html/img/info_jrye/4163/info5.jpg
addedpublic_html/img/info_jrye/4163/info6.jpg
addedpublic_html/img/info_jrye/4163/info7.jpg
addedpublic_html/img/info_jrye/4163/info8.jpg
addedpublic_html/img/info_jrye/4165/info1.jpg
addedpublic_html/img/info_jrye/4165/info10.jpg
addedpublic_html/img/info_jrye/4165/info3.jpg
addedpublic_html/img/info_jrye/4165/info4.jpg
addedpublic_html/img/info_jrye/4165/info5.jpg
addedpublic_html/img/info_jrye/4165/info6.jpg
addedpublic_html/img/info_jrye/4165/info7.jpg
addedpublic_html/img/info_jrye/4165/info8.jpg
addedpublic_html/img/info_jrye/4165/info9.jpg
addedpublic_html/img/info_jrye/4168/info1.jpg
addedpublic_html/img/info_jrye/4168/info2.jpg
addedpublic_html/img/info_jrye/4168/info3.jpg
addedpublic_html/img/info_jrye/4168/info4.jpg
addedpublic_html/img/info_jrye/4169/info1.jpg
addedpublic_html/img/info_jrye/4169/info2.jpg
addedpublic_html/img/info_jrye/4169/info3.jpg
addedpublic_html/img/info_jrye/4169/info4.jpg
addedpublic_html/img/info_jrye/4170/info1.jpg
addedpublic_html/img/info_jrye/4170/info2.jpg
addedpublic_html/img/info_jrye/4170/info4.jpg
addedpublic_html/img/info_jrye/4170/info5.jpg
addedpublic_html/img/info_jrye/4170/info6.jpg
addedpublic_html/img/info_jrye/4171/info1.jpg
addedpublic_html/img/info_jrye/4171/info2.jpg
addedpublic_html/img/info_jrye/4171/info4.jpg
addedpublic_html/img/info_jrye/4171/info6.jpg
addedpublic_html/img/info_jrye/4172/info1.jpg
addedpublic_html/img/info_jrye/4172/info2.jpg
addedpublic_html/img/info_jrye/4172/info4.jpg
addedpublic_html/img/info_jrye/4172/info6.jpg
addedpublic_html/img/item/trade_shop/120/1.jpg
addedpublic_html/img/item/trade_shop/150/1.jpg
addedpublic_html/img/item/trade_shop/60/1.jpg
addedpublic_html/img/item/trade_shop/70/1.jpg
addedpublic_html/img/limited_trade_shop/charaplatform1.png
addedpublic_html/img/limited_trade_shop/charaplatform2.png
addedpublic_html/img/limited_trade_shop/charaplatform3.png
addedpublic_html/img/limited_trade_shop/exchange_paper1.png
addedpublic_html/img/limited_trade_shop/exchange_paper2.png
addedpublic_html/img/limited_trade_shop/exchange_paper3.png
addedpublic_html/img/limited_trade_shop/exchange_paper4.png
addedpublic_html/img/limited_trade_shop/exchange_paper5.png
addedpublic_html/img/limited_trade_shop/exchange_paper6.png
addedpublic_html/img/limited_trade_shop/exchange_paper7.png
addedpublic_html/img/limited_trade_shop/exchangetbutton.png
addedpublic_html/img/limited_trade_shop/gacha_exchangebtn.png
addedpublic_html/img/limited_trade_shop/header.jpg
modifiedpublic_html/index.php
modifiedpublic_html/js/JOLLYROGER.js
modifiedpublic_html/js/jr_main.min.js
modifiedpublic_html/template/Bar-Default.tpl
modifiedpublic_html/template/Bar-SPGachaCheck.tpl
modifiedpublic_html/template/Bar-SPGachaResult.tpl
modifiedpublic_html/template/Bar-SPGachaYamada.tpl
addedpublic_html/template/Bar-SPGacha_508.tpl
addedpublic_html/template/Bar-SPGacha_509.tpl
modifiedpublic_html/template/LimitBreak-List.tpl
modifiedpublic_html/template/LimitedTradeShop-Default.tpl
modifiedpublic_html/template/Main.tpl
modifiedpublic_html/template/Mission.tpl
modifiedpublic_html/template/OceanArea-Shop.tpl
modifiedpublic_html/template/Present-Default.tpl
modifiedpublic_html/template/Present-History.tpl
modifiedpublic_html/template/header_sp.tpl
modifiedpublic_html/template/parts/parts_gacha_season_ticket_button.tpl
modifiedpublic_html/template/parts_limited_trade_shop_info_modal.tpl
Patch body is stored as a separate file to keep this page lightweight.