PR

【12/15】新大陸イベント5 #474

iwamoto opened this at 2020-12-08T10:22:54; closed

Description

opened by iwamoto at 2020-12-08T10:22:54; updated 2023-07-27T15:50:44

【12/15】新大陸イベント05 #468

iwamoto add_label at 2020-12-10T10:46:29: レビュー待ち

Comment

#8632 by iwamoto at 2020-12-10T10:53:37; updated 2020-12-10T10:53:37

@wada
お手すきの際に、こちらレビューをお願い致します。

Comment

#8633 by wada at 2020-12-10T14:22:34; updated 2020-12-10T14:22:34

https://docs.google.com/spreadsheets/d/1AbDAtbB0eYLW5f5Ui5Qol4Oo7Yy_Ik_sVQT4XXMHvF4/edit#gid=21569267
お知らせIDは以下のとおりです。
予告:393
概要:394
報酬:395
ランキング:396

Comment

#8642 by wada at 2020-12-11T11:35:39; updated 2020-12-11T11:35:39

timeの取得はできれば、DateTimeUtil::getCurrentTime()でやってほしい。

Comment

#8643 by wada at 2020-12-11T11:41:25; updated 2020-12-11T11:41:40

優先度高くないですが、開発のイベント期間を調整する場合、configの _configureTestEnv()で調整すると確認しやすいです。

Comment

#8644 by wada at 2020-12-11T11:47:24; updated 2020-12-11T11:47:24

コンパスの説明は、なぜ使えなくなっているのか説明するために、イベント終了後も残しておいて良いと思う。

#JOLLYROGER.js:9653
if(json_data.user_item.item_type == 9){
	if(json_data.user_item.event_end_flg) {
		$('.page_item_confirm').hide();
	}else{
		$('#page_item_select_talisman').show();
	}
}

Comment

#8645 by wada at 2020-12-11T11:51:06; updated 2020-12-11T11:51:06

@iwamoto
確認お願いします。

Comment

#8653 by iwamoto at 2020-12-11T12:29:35; updated 2020-12-11T12:29:35

@wada
諸々対応しましたので、再度ご確認お願いします。

Comment

#8654 by wada at 2020-12-11T12:57:48; updated 2020-12-11T12:57:48

@iwamoto
確認しました。マージOKです

iwamoto merge at 2020-12-11T13:10:46: 【12/15】新大陸イベント5
iwamoto close at 2020-12-11T13:10:46: Close

commit comment

#32 by wada at 2020-12-11T11:31:45; lib/ajax/item_result.inc / old:None new:349
e497dcb65d0c4264da66f702499a9944a115c267

ここの$timeはnullみたい。

Commit range

base945ede8f85aecd756276cb07d73f1b1d286feabe
heade497dcb65d0c4264da66f702499a9944a115c267
base branchjolly/jr-web:develop
head branchjolly/jr-web:event_newisland_5_468

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed23 filesView patch
statusfile
modifiedlib/SubFunc_mission.inc
modifiedlib/ajax/item_result.inc
modifiedlib/ajax/item_select.inc
modifiedlib/conf/class/MissionMonsterConfig.class.php
modifiedlib/conf/class/NewIslandConfig.class.php
modifiedlib/conf/class/NewIslandStageConfig.class.php
modifiedlib/conf/define_y.inc
modifiedlib/exec/event_item_change_gold.sh
modifiedlib/models/Newisland_event_model.php
addedpublic_html/img/mission/newisland/effect/event_no5/ef624.jpg
addedpublic_html/img/mission/newisland/effect/event_no5/ef628.png
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/1.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/2.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/3.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/4.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/5.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/mainpage_mission_btn_icon.png
addedpublic_html/img/mission/newisland/newisland_bar/event_no5/reward.png
modifiedpublic_html/js/JOLLYROGER.js
modifiedpublic_html/js/JOLLYROGER_mission.js
modifiedpublic_html/js/jr_main.js
modifiedpublic_html/js/jr_mission.js
modifiedpublic_html/template/Item.tpl
Patch body is stored as a separate file to keep this page lightweight.

Review comment

#32 by wada at 2020-12-11T11:31:45; lib/ajax/item_result.inc / old:None new:349
e497dcb65d0c4264da66f702499a9944a115c267

ここの$timeはnullみたい。