PR

【6/30】新大陸イベント #923

kouho opened this at 2021-06-30T11:40:58; closed

Description

opened by kouho at 2021-06-30T11:40:58; updated 2024-12-03T10:47:10

【7/6】新大陸イベント #890

web:event_newisland_700
db:event_newisland_700

・新勝利の証対応
・フックモンスター討伐時の消費スタミナ÷10の勝利の証を討伐していないチームメンバーに証の配布対応の追加

フックモンスター討伐までの消費スタミナ保管用に以下のカラムを追加しています。

ALTER TABLE user_event_new_island ADD hook_stamina int(11) default 0;

DB初期化

UPDATE team_data SET event_info = 0,event_info2 = 50,event_info3 = 0 WHERE `del_flg` = 0;
truncate table  user_event_new_island;

マスター更新

master_card

Comment

#11857 by kouho at 2021-06-30T14:18:47; updated 2021-06-30T14:18:47

@iwamoto @wada
お手すきでレビューお願いいたします。

kouho add_label at 2021-06-30T17:54:26: レビュー待ち

Comment

#11869 by wada at 2021-06-30T17:55:12; updated 2021-06-30T17:55:12

@kouho
すいません、リアンネの設定もお願いします。

Comment

#11874 by kouho at 2021-06-30T18:16:53; updated 2021-06-30T18:16:53

@wada
リアンネもリリース& GK設定追加しました

Comment

#11875 by wada at 2021-06-30T18:19:04; updated 2021-06-30T18:19:04

@kouho
ランキングヘッダー画像の追加をお願いします。
達成報酬Lv8の個数が10になっています。

lv:8,pt:2,100	【秘宝隠しのキャプテンキッド】勝利の証	type: 14	id: 2	count: 10

PresentNameConst.class.phpで、1つ上のif文でisset判定しているため、勝利の証の名前が取得できません。

if( isset(self::$_PRESENT_NAMES[$type][$id]) ){
	if($type == \PresentBoxContent::TYPE_CARD_PIECE){
		$piece_names = S_LoadModelClass('Card_piece')->get_card_piece_names();

Comment

#11878 by kouho at 2021-06-30T18:27:47; updated 2021-06-30T18:27:47

@wada
・ランキング報酬ヘッダー画像
・達成報酬 lv8個数
・PresentNameConst
修正しました

Comment

#11879 by wada at 2021-06-30T18:41:03; updated 2021-06-30T18:41:03

@kouho
修正確認しました。

Comment

#11880 by wada at 2021-06-30T18:53:44; updated 2021-06-30T18:53:44

@kouho
Newisland_event_model.phpでのクエリ実行は、
クラス内で統一されているので、各daoクラスに実装してほしいです。

public function get_use_hook_stamina_members(array $members){
}
public function reset_hook_stamina_members(array $members){
}

Comment

#11881 by wada at 2021-06-30T19:02:05; updated 2021-06-30T19:02:05

上記メソッド内のsqlで、ソートするようになっていますが、これはどうしてでしょうか

ORDER BY `hook_stamina` DESC

Comment

#11882 by wada at 2021-06-30T19:26:14; updated 2021-06-30T19:26:14

@kouho
rare_key_present_teamメソッドの中で気になった点コメントしました。

...
#1人だけのチームだと$team_members_noが空でエラーになります
$members_stamina = $this->get_use_hook_stamina_members($team_members_no);
$_presents = array();
#$members_staminaは必ず配列なので、if文がなくても成立します
if(is_array($members_stamina)){
	foreach($members_stamina as $team_user_no => $member_stamina){
		$present_count = floor($member_stamina / $this->_df_new_island['rare_key_present_team']['per_stamina']);
		if($present_count > 0){
			$_presents[] = array_merge($presents, array('user_no' => $team_user_no,'count' => $present_count) );
		}
	}
}
#$_presentsは必ず配列なので、issetがなくても成立します
if(is_array($_presents) && count($_presents) > 0){
	$present_model->send_presents($_presents);
}

Comment

#11885 by kouho at 2021-06-30T20:03:14; updated 2021-06-30T20:03:14

@wada
指摘していただい箇所を修正しました。
また、ORDER BY hook_stamina DESCは削除しています。

Comment

#11886 by iwamoto at 2021-06-30T20:30:15; updated 2021-06-30T20:30:15

@kouho
カーバンクルの覚醒合成ボーナス+20がありませんが、別で設定されているのでしょうか?


仕様書にて
概要に記載のループ報酬と達成報酬記載のループ報酬が異なりますが、どちらが正しいでしょうか?

Comment

#11887 by kouho at 2021-07-01T09:40:23; updated 2021-07-01T09:40:23

@iwamoto
覚醒ボーナスの設定はできていませんでしたので修正しました。
ループ報酬にはリアンネを含めるほうが正でした。

Comment

#11888 by wada at 2021-07-01T10:48:14; updated 2021-07-01T10:48:14

@kouho
修正内容確認しました。大丈夫です。

kouho merge at 2021-07-01T10:57:42: 【6/30】新大陸イベント
kouho close at 2021-07-01T10:57:43: Close

Comment

#11891 by iwamoto at 2021-07-01T11:16:40; updated 2021-07-01T11:16:40

@kouho
証配布時の文言の修正をお願い致します。
貢献度関係ないはずなので

Comment

#11893 by kouho at 2021-07-01T11:22:42; updated 2021-07-01T11:22:42

@iwamoto
討伐までの消費スタミナ量のことを貢献度と表現してまして、
証の獲得個数は消費スタミナをベースにしていることについて、ゲーム内に明記しないという黄さんの要望があり
こちらの表現にしてます。

確かに貢献度というと誤解を招くかもですが良き表現が思いつかずでした。。。

Commit range

base5b62618c117d6fbdd01f984c9f2922e738c2ddf5
head0308dfca4838e1c9cffdb49cb49773bec67bcf7d
base branchjolly/jr-web:develop
head branchjolly/jr-web:event_newisland_890

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed142 filesView patch
statusfile
modifiedlib/SubFunc_mission.inc
modifiedlib/class/const/PresentNameConst.class.php
modifiedlib/conf/class/NewIslandConfig.class.php
modifiedlib/conf/class/NewIslandStageConfig.class.php
modifiedlib/conf/define_y.inc
modifiedlib/models/Card_piece.php
modifiedlib/models/Newisland_event_model.php
modifiedlib/models/dao/user_event_new_island.php
modifiedlib/models/newisland/Newisland_user.php
modifiedpublic_html/img/card/120/222.jpg
modifiedpublic_html/img/card/240/222.jpg
modifiedpublic_html/img/card/320/222.jpg
modifiedpublic_html/img/card/640/222.jpg
modifiedpublic_html/img/card/70/222.jpg
addedpublic_html/img/mission/newisland/10/bg10_0.jpg
addedpublic_html/img/mission/newisland/10/bg11_0.jpg
addedpublic_html/img/mission/newisland/10/bg12_0.jpg
addedpublic_html/img/mission/newisland/10/effect/ef140.png
addedpublic_html/img/mission/newisland/10/effect/ef601.png
addedpublic_html/img/mission/newisland/10/effect/ef607_item.png
addedpublic_html/img/mission/newisland/10/effect/ef620.jpg
addedpublic_html/img/mission/newisland/10/effect/ef623.png
addedpublic_html/img/mission/newisland/10/effect/ef629.png
addedpublic_html/img/mission/newisland/10/effect/ef630.png
addedpublic_html/img/mission/newisland/10/effect/ef632.png
addedpublic_html/img/mission/newisland/10/effect/ef633.png
addedpublic_html/img/mission/newisland/10/effect/ef634.png
addedpublic_html/img/mission/newisland/10/effect/ef644.png
addedpublic_html/img/mission/newisland/10/newisland_pointbar/0.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/1.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/10.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/11.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/12.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/13.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/14.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/15.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/16.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/17.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/18.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/19.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/2.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/20.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/21.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/22.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/23.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/24.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/25.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/26.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/27.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/28.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/29.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/3.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/30.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/31.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/32.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/33.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/34.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/35.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/36.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/37.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/38.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/39.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/4.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/40.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/41.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/42.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/43.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/44.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/45.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/46.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/47.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/48.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/49.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/5.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/50.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/51.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/52.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/53.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/54.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/55.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/56.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/57.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/58.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/59.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/6.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/60.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/61.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/62.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/63.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/64.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/65.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/66.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/67.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/68.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/69.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/7.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/70.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/71.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/72.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/73.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/74.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/75.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/76.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/77.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/78.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/79.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/8.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/80.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/81.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/82.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/83.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/84.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/85.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/86.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/87.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/88.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/89.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/9.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/90.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/91.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/92.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/93.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/94.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/95.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/96.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/97.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/98.gif
addedpublic_html/img/mission/newisland/10/newisland_pointbar/99.gif
addedpublic_html/img/mission/newisland/10/stage_title/10.png
addedpublic_html/img/mission/newisland/10/stage_title/11.png
addedpublic_html/img/mission/newisland/10/stage_title/12.png
addedpublic_html/img/mission/newisland/effect/event_no10/ef624.jpg
addedpublic_html/img/mission/newisland/effect/event_no10/ef628.png
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/1.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/2.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/3.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/4.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/5.jpg
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/mainpage_mission_btn_icon.png
addedpublic_html/img/mission/newisland/newisland_bar/event_no10/reward.png
addedpublic_html/img/ranking/event_island/info10.jpg
modifiedtool/event/test_newisland_event.php
Patch body is stored as a separate file to keep this page lightweight.