PR

【11/17開催】期限付き紅玉販売 #596

suzuki opened this at 2023-11-13T16:36:29; closed

Description

opened by suzuki at 2023-11-13T16:36:29; updated 2023-11-16T11:09:20

仕様書:
https://docs.google.com/spreadsheets/d/1HDpjNZiSvr8clpsNYjVnjT6d5gDjNOOxRajEsHgA4Q8/edit#gid=837096035

同イベント:
jolly/jr-web#3217

Comment

#31705 by suzuki at 2023-11-13T16:58:54; updated 2023-11-13T16:58:54

@kouho @wada

レビューお願いします

Comment

#31707 by wada at 2023-11-13T18:50:28; updated 2023-11-13T18:59:07

@suzuki
master_shop.master_shop_noについて、アイテムパックは10000番台を使用しています。
採番して仕様書に記載しました。
<img src="https://git.dev.d-es.co.jp/gitbucket/jolly/jrye-db/_attached/1699869523195Uui6OoZAXf" width="200">

master_item_pack_info.limit_countは、すでにdaily_limit_countを設定しているので設定不要です。

wada add_label at 2023-11-13T18:54:51: コメントあり

Comment

#31727 by suzuki at 2023-11-15T08:21:04; updated 2023-11-15T08:21:04

@wada
修正しました

Comment

#31731 by wada at 2023-11-15T09:57:21; updated 2023-11-15T09:57:21

@suzuki
ありがとうございます。確認OKです。

wada delete_label at 2023-11-15T09:57:23: コメントあり
wada add_label at 2023-11-15T09:57:25: 和田 LGTM

Comment

#31737 by kouho at 2023-11-15T10:33:58; updated 2023-11-15T10:33:58

@suzuki
確認OKです

kouho add_label at 2023-11-15T10:34:02: 皇甫 LGTM
wada merge at 2023-11-16T11:09:13: 【11/17開催】期限付き紅玉販売
wada close at 2023-11-16T11:09:13: Close
wada delete_branch at 2023-11-16T11:09:20: Shop1117

Commit range

base950464246d479fa62b63e2970a549317f66ffb4f
head5f74b25b947cb6291deed28de6550de5f387f17d
base branchjolly/jrye-db:master
head branchjolly/jrye-db:Shop1117

View commits

Commit details are loaded from Git when a dynamic archive server is running, or can be embedded with --include-commits.
Files changed5 filesView patch
statusfile
modifiedcsv/master_item_pack.csv
modifiedcsv/master_item_pack_info.csv
modifiedcsv/master_shop.csv
modifiedcsv/master_shop_item.csv
modifiedschema/master_item.yml
Patch body is stored as a separate file to keep this page lightweight.